feat(checks,rules): remove deprecated checks and rules #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
reviewed
May 7, 2020
| | [layout-table](https://dequeuniversity.com/rules/axe/3.5/layout-table?application=RuleDescription) | Ensures presentational <table> elements do not use <th>, <caption> elements or the summary attribute | Serious | cat.semantics, wcag2a, wcag131, deprecated | failure | | ||
| | [radiogroup](https://dequeuniversity.com/rules/axe/3.5/radiogroup?application=RuleDescription) | Ensures related <input type="radio"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice, deprecated | failure | | ||
| | [video-description](https://dequeuniversity.com/rules/axe/3.5/video-description?application=RuleDescription) | Ensures <video> elements have audio descriptions | Critical | cat.text-alternatives, wcag2aa, wcag125, section508, section508.22.b, deprecated | needs review | | ||
| | Rule ID | Description | Impact | Tags | Issue Type | |
There was a problem hiding this comment.
This should have better text than just column headers. Something like None would be better. Wdyt?
WilcoFiers
approved these changes
May 7, 2020
| | [radiogroup](https://dequeuniversity.com/rules/axe/3.5/radiogroup?application=RuleDescription) | Ensures related <input type="radio"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice, deprecated | failure | | ||
| | [video-description](https://dequeuniversity.com/rules/axe/3.5/video-description?application=RuleDescription) | Ensures <video> elements have audio descriptions | Critical | cat.text-alternatives, wcag2aa, wcag125, section508, section508.22.b, deprecated | needs review | | ||
| | Rule ID | Description | Impact | Tags | Issue Type | | ||
| | :------ | :---------- | :----- | :--- | :--------- | |
There was a problem hiding this comment.
This shouldn't be an empty table, maybe we can replace this with something like "No deprecated rules"
There was a problem hiding this comment.
I'll create a tech debt ticket and fix it in another pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So begins our breaking changes to axe-core. Also remove 2 unused table checks (
headers-visible-textandth-single-row-column).Partially closes issue: #2189
Reviewer checks
Required fields, to be filled out by PR reviewer(s)