Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

role="presentation" on <hr> tag #2288

Closed
andyricchuiti opened this issue Jun 12, 2020 · 7 comments
Closed

role="presentation" on <hr> tag #2288

andyricchuiti opened this issue Jun 12, 2020 · 7 comments
Assignees
Labels
fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@andyricchuiti
Copy link

when adding a role="presentation" it's showing a violation even though mdn and aria say that an hr tag is allowed to have that role

Expectation: adding a role="presentation" does not trigger a semantic violation

Actual: It currently does

Screen Shot 2020-06-12 at 1 06 36 PM

Motivation: My accessibility team has tagged our code with a violation because our hr tag does not have a role="presentation"


"axe-core": "3.5.3"
"@deque/attest-puppeteer": "^2.10.5"

Browser and Assistive Technology versions

For Tooling issues:
- Node version: 12.13.1 
- Platform: mac 10.15.4
@habeebmh
Copy link

Having the same issue on 2.11.1.

@andyricchuiti
Copy link
Author

@WilcoFiers sorry for at-ting you, but would love guidance on this if there's something i'm missing. thanks for your time

@straker
Copy link
Contributor

straker commented Jun 15, 2020

This seems to be an error on our part. Our list of allowed elements for presentation needs to include the hr element.

@straker straker added fix Bug fixes rules Issue or false result from an axe-core rule labels Jun 15, 2020
@andyricchuiti
Copy link
Author

awesome! thanks so much for looking into it, @straker!

@WilcoFiers
Copy link
Contributor

Thanks for reporting, yeah this is an error. Thank you for reporting!

@padmavemulapati
Copy link

tested with the test file and axe-core3.5.5 aria-allowed-role for <hr role=presentaiton> is not throwing in voilations now, its in passes Passes attachement: ![image](https://user-images.githubusercontent.com/47409579/85302144-6341c380-b4c6-11ea-9632-fefb71d89f75.png) Voilatons attachement: ( aria-allowed-role` node is there but not for


)

Uploading image.png…

@jeankaplansky
Copy link
Contributor

no user-facing docs required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

6 participants