Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't be so greedy in try/catch blocks for the accessible name rules #2405

Closed
straker opened this issue Jul 20, 2020 · 0 comments
Closed

Don't be so greedy in try/catch blocks for the accessible name rules #2405

straker opened this issue Jul 20, 2020 · 0 comments
Assignees
Labels
tech debt Technical debt related tasks

Comments

@straker
Copy link
Contributor

straker commented Jul 20, 2020

Part of #2183 was to ensure the checks caught errors thrown by internal code when children or parents were undefined or there was no actualNode. A lot of the times the try/catch bock surrounds the entire check evaluate code, but it really should only wrap the part of the code that will throw.

@straker straker added the tech debt Technical debt related tasks label Jul 20, 2020
@straker straker self-assigned this Dec 23, 2020
@straker straker closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Technical debt related tasks
Projects
None yet
Development

No branches or pull requests

1 participant