Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-contrast): mark elements with pseudo content as needs review #2613

Merged
merged 4 commits into from
Nov 2, 2020
Merged

fix(color-contrast): mark elements with pseudo content as needs review #2613

merged 4 commits into from
Nov 2, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Oct 29, 2020 •
edited by WilcoFiers
Loading

Checking for pseudo content adds about 1 second on a very large site (26,678 nodes) to our color-contrast check:

Branch Time (ms)
Develop 8413.33
Contrast-pseudo 9649.56

Closes issue: #975

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner October 29, 2020 19:56
@straker straker merged commit fcdbdbc into develop Nov 2, 2020
@straker straker deleted the contrast-pseudo branch November 2, 2020 15:06
@straker straker mentioned this pull request Dec 7, 2020
Open
@myasonik myasonik mentioned this pull request Jan 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers