Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow utils.getFrameContext to accept options #3242

Closed
straker opened this issue Oct 28, 2021 · 1 comment
Closed

allow utils.getFrameContext to accept options #3242

straker opened this issue Oct 28, 2021 · 1 comment
Assignees
@WilcoFiers
Labels
core Issues in the core code (lib/core) pr A pr has been created for the issue
Milestone
Axe-core 4.4

Comments

@straker
Copy link
Contributor

straker commented Oct 28, 2021 •
edited
Loading

Allow the function to accept an object with property iframes: false and return an empty array if set. This just future proofs the function so we can do more if we need to.
@straker straker added this to the Axe-core 4.4 milestone Oct 28, 2021
@straker straker added the core Issues in the core code (lib/core) label Oct 28, 2021
@WilcoFiers WilcoFiers self-assigned this Nov 12, 2021
@WilcoFiers WilcoFiers mentioned this issue Nov 12, 2021
Merged
@WilcoFiers WilcoFiers added the pr A pr has been created for the issue label Nov 12, 2021
@padmavemulapati
Copy link

Verified with the latest dev branch code, iframes allowing true and false options with getFrameContext() , with code snippet:

<html lang="en">
  <title>O hai</title>

  <div class="foo" id="foo">foo</div>
  <iframe></iframe>
</html>

and passing with axe.utils.getFrameContexts({ }, { iframes: true });
getting focusible : true result.
image

also with iframe:false option:
getting below:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WilcoFiers WilcoFiers

Labels
core Issues in the core code (lib/core) pr A pr has been created for the issue
Projects
None yet
Milestone
Axe-core 4.4
Development

No branches or pull requests
3 participants
@WilcoFiers @straker @padmavemulapati