Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dpub role allowances for li element #3253

Closed
Tracked by #369
scottaohara opened this issue Nov 3, 2021 · 4 comments
Closed
Tracked by #369

update dpub role allowances for li element #3253

scottaohara opened this issue Nov 3, 2021 · 4 comments
Labels
core Issues in the core code (lib/core) rule metadata Issues in the rule metadata code (lib/rules)

Comments

@scottaohara
Copy link
Contributor

scottaohara commented Nov 3, 2021

ARIA in HTML is removing the allowances for doc-biblioentry and doc-endnote on <li> elements.

These are not technically valid children of ul, ol or role=list elements per the ARIA spec. Due to this, these roles are being deprecated in DPUB ARIA 1.1. Authors should be using standard list elements, or role=list and role=listitem elements instead.

Edited issue description to provide more clarity / per the closure of the original PR.

@straker
Copy link
Contributor

straker commented Nov 4, 2021

Moving conversation from the pr. In essence, we won't remove the roles from the allowed list since they are only deprecated and as far as we know don't cause problems with screen readers if present. Will need to figure out how we want to handle and announce to the user deprecations in the ARIA spec.

@straker straker added rule metadata Issues in the rule metadata code (lib/rules) core Issues in the core code (lib/core) labels Nov 5, 2021
@scottaohara
Copy link
Contributor Author

@straker I saw that #3280 was merged, but that this issue is still open. I think this can be closed per your comment in the PR, but wanted to verify before closing myself.

@straker
Copy link
Contributor

straker commented Jan 4, 2022

Yep. I think this can be closed as well. Thanks for the reminder.

@danielweck
Copy link

This issue was partially fixed (a bug was mistakenly introduced), see new issue #3372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues in the core code (lib/core) rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants