-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow role=combobox for button and input type=button #3353
Comments
closes dequelabs#3353 - Adds `role=combobox` to the `<button>` element. - Adds `role=combobox` and `role=checkbox` to the `<input type=button>` element.
How do I configure the latest version of Axe to pass when a button has the role of combobox? |
I don't think the PR for this change has landed yet, @MattyBalaam. @WilcoFiers what else needs to happen here? I think I addressed what I needed to in the PR? Understood if other priorities have punted this, but it's unclear what else is needed if not just 'time'? |
I was wondering if someone had a tip for some config which can be used as a workaround while we wait for this to land. |
For a workaround you can configure the axe.configure({
standards: {
htmlElms: {
button: {
allowedRoles: [
'checkbox',
'combobox',
'link',
'menuitem',
'menuitemcheckbox',
'menuitemradio',
'option',
'radio',
'switch',
'tab'
]
}
}
}
}) @scottaohara I think this might have fallen through the cracks (as well as a few other of your prs). I'll go back and look into them. |
@straker , hi, i am using the axe DevTools plugin on chrome and the |
@adcortes We are planning a release later this month which should include this change. After axe-core releases, it'll probably be another couple of weeks or so before it is released into the extension. |
ARIA in HTML is planning to allow
role=combobox
on abutton
andinput type=button
element.button role=combobox
test caseAdditionally, the ARIA in HTML PR adds
role=checkbox
as an allowed role forinput type=button
to match thebutton
element allowances. This was an oversight in the spec which this PR will help correct.The text was updated successfully, but these errors were encountered: