Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(meta-refresh): Add WCAG's 20-hour exception #3525

Merged
merged 4 commits into from
Jul 4, 2022
Merged

fix(meta-refresh): Add WCAG's 20-hour exception #3525

merged 4 commits into from
Jul 4, 2022

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Jun 29, 2022 •
edited
Loading

  1. Ensure that redirects after 20 hours are passed
  2. Improve the accuracy of the redirect number parsing
  3. Add options for minDelay and maxDelay, to make the check configurable
  4. Make the rule inapplicable when there's no content attribute
  5. Add more integration tests

Closes issue: #3496

@WilcoFiers WilcoFiers requested a review from a team as a code owner June 29, 2022 11:52
@WilcoFiers WilcoFiers requested a review from straker June 29, 2022 13:02
straker
straker previously requested changes Jun 29, 2022
View reviewed changes
lib/checks/navigation/meta-refresh-evaluate.js Outdated Show resolved Hide resolved
test/checks/navigation/meta-refresh.js Outdated Show resolved Hide resolved
test/checks/navigation/meta-refresh.js Outdated Show resolved Hide resolved
test/checks/navigation/meta-refresh.js Outdated Show resolved Hide resolved
test/checks/navigation/meta-refresh.js Outdated Show resolved Hide resolved
test/integration/full/meta-refresh/meta-refresh-fail.js Outdated Show resolved Hide resolved
test/integration/full/meta-refresh/meta-refresh-inapplicable.js Outdated Show resolved Hide resolved
test/integration/full/meta-refresh/meta-refresh-pass.js Outdated Show resolved Hide resolved
@WilcoFiers WilcoFiers requested a review from straker June 30, 2022 10:29
@WilcoFiers WilcoFiers merged commit 5beb6c3 into develop Jul 4, 2022
@WilcoFiers WilcoFiers deleted the meta-refresh-update branch July 4, 2022 11:17
@WilcoFiers WilcoFiers mentioned this pull request Jul 4, 2022
Merged
straker pushed a commit that referenced this pull request Jul 13, 2022
@WilcoFiers @straker
fix(meta-refresh): Add WCAG's 20-hour exception (#3525)
c00bdd0 
* fix(meta-refresh): Add WCAG's 20-hour exception

* put refreshDelay in check data

* Address feedback

* More tweaks
@Shubhabrata08 Shubhabrata08 mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanb dylanb dylanb approved these changes

@straker straker Awaiting requested review from straker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WilcoFiers @dylanb @straker