Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn during test when Node 12+ isn't used #3544

Closed
WilcoFiers opened this issue Jul 13, 2022 · 2 comments
Closed

Warn during test when Node 12+ isn't used #3544

WilcoFiers opened this issue Jul 13, 2022 · 2 comments
Labels
good first issue For first-time contributors tech debt Technical debt related tasks

Comments

@WilcoFiers
Copy link
Contributor

PR #3538, axe-core is back to using Node v4 as its minimum. That's true enough when it comes to importing and using axe, but Node 12+ is required for building / testing. We should add an explicit warning of sorts to call out when an older version of Node is used to build / test axe.

I am very open to how to do this. Easiest might be to add some little script that returns exit code 1 in the pretest and prebuild scripts in package.json.

@WilcoFiers WilcoFiers added tech debt Technical debt related tasks good first issue For first-time contributors labels Jul 13, 2022
@pandu-supriyono
Copy link
Contributor

pandu-supriyono commented Jul 20, 2022

Hi, I have the time and motivation to look into this.

Do I understand correctly that we want to produce a fatal error with exit code 1 if the minimum Node version isn't found instead of a warning message that exits with exit code 0?

Edit: As a side note, it would also be useful to include this requirement in the developer guide.

@straker
Copy link
Contributor

straker commented Jul 26, 2022

Thanks for taking this on @pandu-supriyono. I believe having the build script or test script exit with a clear message and exit code 1 if Node version is < 12 would be fine. Adding a note in the developer guide on minimum Node version would also be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue For first-time contributors tech debt Technical debt related tasks
Projects
None yet
Development

No branches or pull requests

3 participants