fix(valid-lang): run on aria-hidden text #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Sep 5, 2022
| 'use strict'; | ||
|
|
||
| var fixture = document.getElementById('fixture'); | ||
| var shadowSupported = axe.testUtils.shadowSupport.v1; | ||
| var isHiddenWithCSSFn = axe.commons.dom.isHiddenWithCSS; | ||
| var isHiddenWithCSS = axe.commons.dom.isHiddenWithCSS; |
There was a problem hiding this comment.
I have no idea why we did this, but I thought it should be changed.
WilcoFiers
commented
Sep 5, 2022
| @@ -3,7 +3,7 @@ import getImplicitRole from './implicit-role'; | |||
| import getRoleType from './get-role-type'; | |||
| import isAriaRoleAllowedOnElement from './is-aria-role-allowed-on-element'; | |||
| import { tokenList, isHtmlElement, getNodeFromTree } from '../../core/utils'; | |||
| import AbstractVirtuaNode from '../../core/base/virtual-node/abstract-virtual-node'; | |||
| import AbstractVirtualNode from '../../core/base/virtual-node/abstract-virtual-node'; | |||
There was a problem hiding this comment.
Unrelated, but I spotted this typo. Figured I might as well fix it.
WilcoFiers
commented
Sep 5, 2022
| @@ -10,11 +10,17 @@ | |||
| <p xml:lang="en-US" lang="gibberish-US" id="fail3">Mix</p> | |||
| <p lang=" " id="fail4">English</p> | |||
|
|
|||
| <p lang="invalid" id="pass7"> <!-- ignore --> </p> | |||
| <p lang="invalid" id="pass7"><!-- ignore --></p> | |||
There was a problem hiding this comment.
Hmm, wonder why prettier did that.... Not sure it matters?
WilcoFiers
force-pushed
the
valid-lang-act-rix
branch
from
037e030
to
315b2ec
Compare
straker
previously requested changes
Sep 6, 2022
straker
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #3633