feat: Deprecated Internet Explorer support #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
force-pushed
the
deprecate-ie11
branch
from
5bfac9d
to
7001bb7
Compare
straker
previously requested changes
Sep 7, 2022
| @@ -52,18 +52,6 @@ jobs: | |||
| key: v9-cache-unix-{{ checksum "package-lock.json" }} | |||
There was a problem hiding this comment.
There's also the orbs: win, restore_dependency_cache_win, and win_box steps that can be removed
| '<span id="shadowTarget" style="color: #ccc;">Text</span>' + | ||
| '</div>'; | ||
| axe.testUtils.flatTreeSetup(fixture); | ||
| (shadowSupported ? it : xit)( |
There was a problem hiding this comment.
With IE11 gone all our tests run in browsers that support shadow dom (Chrome and Firefox). We should get rid of shadowSupported as well (I'm fine if it's a separate pr / tech debt ticket).
| @@ -429,23 +426,17 @@ describe('preload cssom integration test', function() { | |||
| commonTestsForRootNodeAndNestedFrame(); | |||
| }); | |||
|
|
|||
| describe('tests for nested document', function() { | |||
| before(function() { | |||
| if (!nestedFrame || isIE11) { | |||
There was a problem hiding this comment.
Is there a chance that nestedFrame will ever be false that we need the if statement still?
There was a problem hiding this comment.
I have no idea why this was ever there. It wasn't necessary. (otherwise the tests would have failed)
straker
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of axe-core 4.5, Internet Explorer 11 is deprecated. Support will be fully dropped with the release of axe-core 5.0, which will come at least 6 months after the 5.0 release to give sufficient time to upgrade.
As of this pull request, we will no longer run automated tests on Internet Explorer. Any bugs reported against IE11 will be investigated and addressed, and the axe-core team will continue to keep limitations imposed by Internet Explorer in mind.
Closes issue: #3534