Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color-contrast-enhanced): avoid duplicates between color-contrast and color-contrast-enhanced #3714

Merged
merged 4 commits into from
Oct 13, 2022

Conversation

straker
Copy link
Contributor

@straker straker commented Oct 11, 2022

Closes issue: #3612

@straker straker requested a review from a team as a code owner October 11, 2022 21:54
lib/commons/color/get-background-color.js Outdated Show resolved Hide resolved
test/checks/color/color-contrast.js Outdated Show resolved Hide resolved
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I figured out the ACT issue. Probably the same as this one: #3719 Since we're avoiding overlap with the AAA rule in axe-core, to get the ACT rule tested, we need to map both axe-core rules to the ACT rule for AAA. You'll want to add 09o5cg to the actIds prop on rules/color-contrast.json, and add color-contrast to axeRules in text-contrast-enhanced-09o5cg.spec.js.

test/checks/color/color-contrast.js Outdated Show resolved Hide resolved
straker and others added 2 commits October 13, 2022 10:25
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants