fix: prevent undefined relatedNodes from halting axe #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
approved these changes
Nov 14, 2022
dylanb
reviewed
Nov 15, 2022
| @@ -10,19 +10,19 @@ function normalizeRelatedNodes(node, options) { | |||
| .forEach(checkRes => { | |||
| checkRes.relatedNodes = checkRes.relatedNodes.map(relatedNode => { | |||
| var res = { | |||
| html: relatedNode.source | |||
| html: relatedNode?.source ?? 'Undefined' | |||
There was a problem hiding this comment.
I would have made this all lowercase so it looks like A Javascript stringification of a variable with a value of undefined, but nbd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the reporter throwing an error when the relatedNode is undefined.
Instead the source is now reported as "Undefined"
Closes issues #3733 and #3627