Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-contrast): consider -webkit-text-stroke & -webkit-text-fill-color #3791

Merged
merged 5 commits into from
Nov 28, 2022
Merged

fix(color-contrast): consider -webkit-text-stroke & -webkit-text-fill-color #3791

merged 5 commits into from
Nov 28, 2022

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Nov 21, 2022 •
edited
Loading

Consider -webkit-text-stroke and its cousin -webkit-text-fill-color when calculating contrast

Closes #3356

@WilcoFiers WilcoFiers marked this pull request as ready for review November 22, 2022 11:09
@WilcoFiers WilcoFiers requested a review from a team as a code owner November 22, 2022 11:09
@WilcoFiers WilcoFiers mentioned this pull request Nov 22, 2022
Merged
@WilcoFiers WilcoFiers changed the title fix(color-contrast): use text-stroke colors fix(color-contrast): use -webkit-text-stroke colors Nov 22, 2022
@WilcoFiers WilcoFiers changed the title fix(color-contrast): use -webkit-text-stroke colors fix(color-contrast): consider -webkit-text-stroke & -webkit-text-fill-color Nov 22, 2022
straker
straker previously requested changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@straker straker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo, rest looks good

test/commons/color/get-foreground-color.js Outdated Show resolved Hide resolved
@WilcoFiers @straker
Update test/commons/color/get-foreground-color.js
ea8ee48 
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
@WilcoFiers WilcoFiers merged commit 228daf1 into develop Nov 28, 2022
@WilcoFiers WilcoFiers deleted the text-stroke branch November 28, 2022 16:30
This was referenced Dec 5, 2022
Closed
Closed
@attest-team-ci attest-team-ci mentioned this pull request Dec 12, 2022
Merged
@Shubhabrata08 Shubhabrata08 mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-webkit-text-stroke- vs "insufficient contrast"
2 participants
@WilcoFiers @straker