Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is-valid-autocomplete missing token #3854

Closed
1 task done
Mottie opened this issue Jan 11, 2023 · 2 comments · Fixed by #3866
Closed
1 task done

is-valid-autocomplete missing token #3854

Mottie opened this issue Jan 11, 2023 · 2 comments · Fixed by #3866
Assignees
Labels
fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule standards Issues in the ARIA standards objects (lib/standards)
Milestone

Comments

@Mottie
Copy link

Mottie commented Jan 11, 2023

Product

axe-core

Product Version

4.5.2

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

Allow "webauthn" as a token in the autocomplete attribute with a maximum of 5 tokens.

Actual

Shows an "autocomplete attribute must be used correctly" issue

How to Reproduce

Test with "webauthn" in the autocomplete value

<input required autocomplete="webauthn work email" type="email" name="email" id="work_email">

Additional context

Note: I don't have a need for this addition, it's just something I noticed while trying to figure out if section- can be followed by any text.

@Mottie Mottie added the ungroomed Ticket needs a maintainer to prioritize and label label Jan 11, 2023
@WilcoFiers
Copy link
Contributor

webauthn is new in HTML. It wasn't there when we built this. Thank you for sharing. We'll be sure to update.

@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule standards Issues in the ARIA standards objects (lib/standards) and removed ungroomed Ticket needs a maintainer to prioritize and label labels Jan 16, 2023
@WilcoFiers WilcoFiers added this to the Axe-core 4.7 milestone Jan 16, 2023
@WilcoFiers WilcoFiers self-assigned this Jan 20, 2023
@WilcoFiers WilcoFiers added the pr A pr has been created for the issue label Jan 20, 2023
@padmavemulapati
Copy link

Validated with the latest axe-core develop branch code base,
autocomplete-valid rule now allowing for webauthn which was not implemented earlier.
Here auto-complete-valid rule is failing when we pass webauthn as webauthn work email
Passing for the below webauthn tokens

autocomplete="email webauthn" 
 autocomplete="section-foo email webauthn" 
 autocomplete="section-foo work email webauthn" 
 autocomplete="section-foo billing work email webauthn" 

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule standards Issues in the ARIA standards objects (lib/standards)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants