fix(aria-input-field-name): skip combobox popups #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Jan 25, 2023
| @@ -3,7 +3,7 @@ import getImplicitRole from './implicit-role'; | |||
| import getGlobalAriaAttrs from '../standards/get-global-aria-attrs'; | |||
| import isFocusable from '../dom/is-focusable'; | |||
| import { getNodeFromTree } from '../../core/utils'; | |||
| import AbstractVirtuaNode from '../../core/base/virtual-node/abstract-virtual-node'; | |||
| import AbstractVirtualNode from '../../core/base/virtual-node/abstract-virtual-node'; | |||
WilcoFiers
commented
Jan 25, 2023
|
|
||
| const isCombobox = node => node && getRole(node) === 'combobox'; | ||
|
|
||
| function nearestParentWithRole(vNode) { |
There was a problem hiding this comment.
We were using closest before, but this is more accurate and faster. It's not perfect though. We should really have a method that can tell you the owner. I spent more time on this PR than I expected to already, and didn't want to bloat this further. I opened a tech debt ticket: #3888
WilcoFiers
commented
Jan 25, 2023
| } | ||
|
|
||
| if (!virtualNode.actualNode) { | ||
| throw new Error('Unable to determine combobox popup without an actualNode'); |
There was a problem hiding this comment.
I didn't think we needed additional virtualNode tests, but let me know if I missed anything.
straker
previously requested changes
Jan 25, 2023
straker
approved these changes
Jan 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3860