Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why did object-alt and aria-required-children stopped failing in 4.5.0? #3887

Closed
adamraine opened this issue Jan 24, 2023 · 2 comments
Closed

Why did object-alt and aria-required-children stopped failing in 4.5.0? #3887

adamraine opened this issue Jan 24, 2023 · 2 comments
Labels
question

Comments

@adamraine
Copy link

Product

axe-core

Question

In axe-core 4.4.3 the following page would fail on object-alt and aria-required-children:

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <meta http-equiv="X-UA-Compatible" content="IE=edge">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Test a11y</title>
</head>
<body>
  <h1>Test a11y</h1>
  <object id="object-alt"></object> 
  <div id="aria-required-children" role="radiogroup">
    <div></div>
  </div>
</body>
</html

However, in version >=4.5.0 no failures are reported on this page. I couldn't find anything the changelog to explain why this happened, but I'm assuming I missed something. What changes in version 4.5.0 caused this to happen?
@adamraine adamraine added question ungroomed Ticket needs a maintainer to prioritize and label labels Jan 24, 2023
@adamraine adamraine changed the title object-alt and aria-required-children stopped failing in 4.5.0 Why did object-alt and aria-required-children stopped failing in 4.5.0? Jan 24, 2023
@adamraine adamraine mentioned this issue Jan 24, 2023
Merged
@straker
Copy link
Contributor

straker commented Jan 24, 2023 •
edited
Loading

Thanks for the question. For object-alt, we added a fix to ignore objects without a data attribute, and for aria-required-children we added a fix to remove the requiredOwned for radiogroup.

@straker straker removed the ungroomed Ticket needs a maintainer to prioritize and label label Jan 24, 2023
@adamraine
Copy link
Author

Thanks for the quick response @straker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@straker @adamraine