Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify aria-busy remediation message #3934

Closed
WilcoFiers opened this issue Mar 7, 2023 · 1 comment · Fixed by #3954
Closed

Clarify aria-busy remediation message #3934

WilcoFiers opened this issue Mar 7, 2023 · 1 comment · Fixed by #3954
Labels
fix Bug fixes good first issue For first-time contributors rule metadata Issues in the rule metadata code (lib/rules)

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Mar 7, 2023

We had some confusion about this message:

Element has no aria-busy="true" attribute

This doesn't explain when aria-busy would be appropriate. I think the following would be better:

Element uses aria-busy="true" while showing a loader

This required a small change to lib/checks/aria/aria-busy.json.

@WilcoFiers WilcoFiers added fix Bug fixes rule metadata Issues in the rule metadata code (lib/rules) good first issue For first-time contributors labels Mar 7, 2023
@straker
Copy link
Contributor

straker commented Mar 23, 2023

To expand on this issue, we may not want to show the aria-busy remediation message when there are unallowed roles. Otherwise the remediation message suggests that adding aria-busy will fix the issue when it won't.

"Fix any of the following:
  Element has children which are not allowed: button
  Element has no aria-busy="true" attribute"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes good first issue For first-time contributors rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants