fix(color-contrast): support CSS 4 color spaces #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
changed the title
straker
commented
May 12, 2023
| assert.equal(c.blue, 200); | ||
| assert.equal(c.alpha, 1); | ||
| }); | ||
| it.skip('allows exponent numbers', () => { |
There was a problem hiding this comment.
Colorjs doesn't handle this, but we decided that's ok
There was a problem hiding this comment.
We should open an issue for this with colorjs.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
WilcoFiers
approved these changes
May 15, 2023
| it('allows oklab', () => { | ||
| const c = new Color(); | ||
| c.parseColorFnString('oklab(0.697 -0.107 0.023)'); | ||
| assert.equal(c.red, 77); |
There was a problem hiding this comment.
Weird, chrome devtools gives me 76 for this. 🤷
Merged
|
Caused #4127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
hwb(),lab(),lch(),oklab(), andoklch()color spacesCloses: #4007