Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deprecate impact on checks, use rules instead #4114

Merged
merged 3 commits into from
Aug 1, 2023
Merged

feat: Deprecate impact on checks, use rules instead #4114

merged 3 commits into from
Aug 1, 2023

Conversation

WilcoFiers
Copy link
Contributor

Impact is now required on rules, rather than on checks. This makes impact on checks obsolete. As of axe-core 4.8, impact on checks is deprecated.

Closes: #4066

@WilcoFiers WilcoFiers requested a review from a team as a code owner August 1, 2023 10:49
straker
straker requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the following rules, which means the rule validator is not working / running?

  • aria-roles
  • aria-valid-attr-value
  • scope-attr-valid

straker
straker approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out they were already updated (but my local branch was not)

@WilcoFiers WilcoFiers merged commit 2cc5547 into develop Aug 1, 2023
3 checks passed
@WilcoFiers WilcoFiers deleted the rule-impact branch August 1, 2023 14:28
@attest-team-ci attest-team-ci mentioned this pull request Sep 6, 2023
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 3, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 19, 2024
Open
@organich organich mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give rules a consistent impact
2 participants
@WilcoFiers @straker