Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getTargetSize in target-size check #4120

Open
straker opened this issue Aug 7, 2023 · 1 comment
Open

Use getTargetSize in target-size check #4120

straker opened this issue Aug 7, 2023 · 1 comment
Labels
tech debt Technical debt related tasks

Comments

@straker
Copy link
Contributor

straker commented Aug 7, 2023

We didn't do this as part of #4117 but we should update the target-size check to use the new dom.getTargetSize function and replace all uses of nodeRect with the target size.

@straker
Copy link
Contributor Author

straker commented Aug 9, 2023

Part of this ticket will need to include commonizing the handling of descendants of targets that can change the true clickable size of the target (such as an image inside a link) and also shouldn't be counted as an obscuring element to the target.

See #4125 (comment) and #4125 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Technical debt related tasks
Projects
None yet
Development

No branches or pull requests

1 participant