Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding the wcag131 tag to the aria-hidden-body rule #4349

Merged

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Feb 29, 2024

<< Describe the changes >>
This PR adds the wcag412 tag to the aria-hidden-body rule, making it easier for the testing engine to detect issues.

Closes #4315

Signed-off-by: Christine <shecoder30@gmail.com>
Signed-off-by: Christine <shecoder30@gmail.com>
@CBID2 CBID2 requested a review from a team as a code owner February 29, 2024 04:43
@CBID2
Copy link
Contributor Author

CBID2 commented Mar 3, 2024

Hi @straker! :) My PR is ready for review! :)

Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing because of this. Also please update the PR title, you're adding wcag131, not 412.

lib/rules/aria-hidden-body.json Show resolved Hide resolved
@CBID2 CBID2 changed the title feat: adding the wcag 412 tag to the aria hidden body rule feat: adding the wcag wcag131 tag to the aria hidden body rule Mar 4, 2024
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@CBID2
Copy link
Contributor Author

CBID2 commented Mar 4, 2024

wcag131

Done @WilcoFiers

@WilcoFiers
Copy link
Contributor

Reviewed for security.

@WilcoFiers WilcoFiers merged commit dd4c3c3 into dequelabs:develop Mar 5, 2024
14 of 15 checks passed
@WilcoFiers WilcoFiers changed the title feat: adding the wcag wcag131 tag to the aria hidden body rule feat: adding the wcag131 tag to the aria-hidden-body rule Mar 5, 2024
@CBID2 CBID2 deleted the adding-a-tag-to-the-aria-hidden-body-rule branch March 5, 2024 12:26
WilcoFiers added a commit that referenced this pull request Mar 25, 2024
##
[4.9.0](v4.8.4...v4.9.0)
(2024-03-25)

### Features

- adding the wcag131 tag to the aria-hidden-body rule
([#4349](#4349))
([dd4c3c3](dd4c3c3)),
closes [#4315](#4315)
- **checks:** deprecate aria-busy check
([#4356](#4356))
([be0b555](be0b555)),
closes [#4347](#4347)
[#4340](#4340)
- **color:** add color channel values and luminosity, saturation, clip
functions ([#4366](#4366))
([9e70199](9e70199)),
closes
[/github.com//pull/4365/files#r1517706612](https://github.com/dequelabs//github.com/dequelabs/axe-core/pull/4365/files/issues/r1517706612)
- **i18n:** add Greek Translations
([#3836](#3836))
([3ea9a48](3ea9a48))
- **i18n:** Add Italian translation
([#4344](#4344))
([de1baa9](de1baa9))
- **i18n:** Add Simplified Chinese translation
([#4379](#4379))
([bda7c8d](bda7c8d))
- **i18n:** Add Taiwanese Mandarin translation
([#4299](#4299))
([c5e11de](c5e11de))

### Bug Fixes

- Add LICENSE-3RD-PARTY.txt file
([#4304](#4304))
([daa0fe6](daa0fe6))
- add Object.values polyfill for node <=6
([#4274](#4274))
([5eb867b](5eb867b))
- **aria-required-children:** avoid confusing aria-busy message in
failures ([#4347](#4347))
([591607d](591607d)),
closes [#fail13](https://github.com/dequelabs/axe-core/issues/fail13)
[#4340](#4340)
- avoid reading element-specific node properties of non-element node
types ([#4317](#4317))
([b853b18](b853b18)),
closes [#4316](#4316)
[#4316](#4316)
- **color-contrast:** handle text that is outside `overflow: hidden`
ancestor ([#4357](#4357))
([bdb7300](bdb7300)),
closes [#4253](#4253)
- **color-contrast:** support color blend modes hue, saturation, color,
luminosity ([#4365](#4365))
([7ae4761](7ae4761))
- **d.ts:** RawNodesResult issues
([#4229](#4229))
([d660518](d660518))
- **d.ts:** RunOptions.reporter can be any string
([#4218](#4218))
([e53f5c5](e53f5c5))
- **i18n:** update Italian translations
([#4377](#4377))
([4d65d4b](4d65d4b))
- **listitem:** clarify roleNotValid message
([#4374](#4374))
([0f8a9af](0f8a9af))
- **scrollable-region-focusable:** missing wcag213 tag
([#4201](#4201))
([0080a72](0080a72))
- **target-size:** always pass 10x targets (avoid perf bottleneck)
([#4376](#4376))
([be327c4](be327c4))
- **target-size:** do not crash for nodes with many overlapping widgets
([#4373](#4373))
([1dbea83](1dbea83)),
closes [#4359](#4359)
[#4359](#4359)
[#4360](#4360)
- **utils/get-selector:** ignore 'xmlns' attribute when generating a
selector ([#4303](#4303))
([938b411](938b411))

This PR was opened by a robot 🤖 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have the aria-hidden-body rule map to 1.3.1
2 participants