Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shadow DOM support to list checks #439

Merged
merged 4 commits into from
Jul 16, 2017
Merged

Add shadow DOM support to list checks #439

merged 4 commits into from
Jul 16, 2017

Conversation

WilcoFiers
Copy link
Contributor

This should solve #427 and #428.

dylanb
dylanb approved these changes Jul 15, 2017
View reviewed changes
Copy link
Contributor

@dylanb dylanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could add some tests for failures for each of the checks but its not mandatory due to the way these are implemented

@WilcoFiers WilcoFiers merged commit d92c1a1 into shadowDOM Jul 16, 2017
@dylanb dylanb deleted the sd/list-checks branch July 16, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanb dylanb dylanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilcoFiers @dylanb