fix(target-size): ignore descendant elements in shadow dom #4410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
commented
Apr 15, 2024
| @@ -2,6 +2,7 @@ import findNearbyElms from './find-nearby-elms'; | |||
| import isInTabOrder from './is-in-tab-order'; | |||
| import { splitRects, hasVisualOverlap } from '../math'; | |||
| import memoize from '../../core/utils/memoize'; | |||
There was a problem hiding this comment.
This is a separate import on purpose as memoize when destructred from the utils import path causes problems for esbuild and it doesn't hoist the memoize function high enough in the build for functions to use it. We've gotten around that by importing it directly.
WilcoFiers
previously requested changes
Apr 17, 2024
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
straker
commented
Apr 17, 2024
| @@ -411,4 +410,19 @@ describe('target-size tests', function () { | |||
| '#obscurer2' | |||
| ]); | |||
| }); | |||
|
|
|||
| it('ignores descendants of the target that are in shadow dom', () => { | |||
| fixture.innerHTML = | |||
There was a problem hiding this comment.
shadowCheckSetup assumes that the target is either the shadow root node or inside the shadow content. This isn't true for the DOM I was testing and I didn't want to try to update the function in this PR to account for content which uses both.
WilcoFiers
approved these changes
Apr 23, 2024
Merged
WilcoFiers
added a commit
that referenced
this pull request
May 6, 2024
### [4.9.1](v4.9.0...v4.9.1) (2024-05-06) ### Bug Fixes - Prevent errors when loading axe in a page with prototype.js - **aria-allowed-attr:** allow meter role allowed aria-\* attributes on meter element ([#4435](#4435)) ([7ac6392](7ac6392)) - **aria-allowed-role:** add gridcell, separator, slider and treeitem to allowed roles of button element ([#4398](#4398)) ([4788bf8](4788bf8)) - **aria-roles:** correct abstract roles (types) for aria-roles([#4421](#4421)) - **aria-valid-attr-value:** aria-controls & aria-haspopup incomplete ([#4418](#4418)) - fix building axe-core translation files with region locales ([#4396](#4396)) ([5c318f3](5c318f3)), closes [#4388](#4388) - **invalidrole:** allow upper and mixed case role names ([#4358](#4358)) ([105016c](105016c)), closes [#2695](#2695) - **isVisibleOnScreen:** account for position: absolute elements inside overflow container ([#4405](#4405)) ([2940f6e](2940f6e)), closes [#4016](#4016) - **label-content-name-mismatch:** better dismiss and wysiwyg symbolic text characters ([#4402](#4402)) - **region:** Decorative images ignored by region rule ([#4412](#4412)) - **target-size:** ignore descendant elements in shadow dom ([#4410](#4410)) ([6091367](6091367)) - **target-size:** pass for element that has nearby elements that are obscured ([#4422](#4422)) ([3a90bb7](3a90bb7)), closes [#4387](#4387) This PR was opened by a robot 🤖 🎉 (And updated by @WilcoFiers )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds to the
.eslintrcto error ifnode.contains()orvNode.actualNode.contains()or used. (also upgraded thenode.attributeserror to account forvNode.actualNode.attributesas I noticed it was missing).Closes: #4194