feat: Add shadow DOM to duplicate-img-label check #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Jul 17, 2017
| // Get all visible images in the composed tree of the current node | ||
| const images = axe.utils.querySelectorAll(virtualNode, 'img') | ||
| // Ignore hidden or role=none/presentation images | ||
| .filter(({ actualNode }) => (axe.commons.dom.isVisible(actualNode) && |
There was a problem hiding this comment.
@dylanb Not sure if this was a bug, or if this is intentional. isVisible has a screenreader flag, should this function use that flag? I'm not sure why we care here if the image is positioned off screen or not. Thoughts?
dylanb
approved these changes
Jul 17, 2017
|
|
||
| return false; | ||
| // See if any of the images duplicate the node's text | ||
| return images.some(img => |
There was a problem hiding this comment.
array.some returns a boolean.
marcysutton
reviewed
Jul 17, 2017
| var node = axe.utils.querySelectorAll(axe._tree[0], target || '#target')[0]; | ||
|
|
||
| var node; | ||
| if (typeof target === 'string') { |
There was a problem hiding this comment.
We needed this testutils file after all 👍
There was a problem hiding this comment.
Yeah, this is very nice to have hanging around.
WilcoFiers
added a commit
that referenced
this pull request
Jul 18, 2017
* feat: Add shadow DOM to duplicate-img-label check * fix: Use tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #430.