Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure rule/check options can be configured to override default selectors #644

Closed
marcysutton opened this issue Dec 13, 2017 · 2 comments
Closed
Assignees
Labels

Comments

@marcysutton
Copy link
Contributor

marcysutton commented Dec 13, 2017

We've made a change to axe.commons.aria.lookupTable to make the API appear less private, as compared to axe.commons.aria._lut. However, rather than creating additional APIs for configuring rules, we should better utilize a tool we already have: specifying options.

axe-core definitely allows you to specify options in checks. Options are also used in the color contrast rule, but we should do some investigating to see if this is actually working. This issue will be satisfied when options can be used to add additional attributes/selectors for existing rules.

The lookupTable could still be used to retrieve defaults, if needed, but in terms of configuring rules, options are the way to go. We should make sure this is easy to do for existing rules with axe.configure, not just custom ones.

@marcysutton
Copy link
Contributor Author

Closed with #673.

@marcysutton
Copy link
Contributor Author

An implementation note: this fix does not extend to all rules/checks, but the ones specifically requested (aria-allowed-attr, aria-required-attr). A broader, long-term solution would be to implement an Accessibility Supported API, but that's a huge undertaking and isn't currently prioritized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant