fix(commons/dom): fix isFocusable functions by checking screenreader visibility and enabledness #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ddfell0w
force-pushed
the
check-if-focus-disabled
branch
from
ea6f133
to
48e7326
Compare
dylanb
approved these changes
Dec 19, 2017
|
@dylanb nooo problem. @WilcoFiers tagging you here in case you're deciding when to merge, closed the other PR |
visibility and enabledness Adds tests for disabled/AT-hidden elements with tabindex fixes dequelabs#647
0ddfell0w
force-pushed
the
check-if-focus-disabled
branch
from
48e7326
to
0baf768
Compare
WilcoFiers
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for disabled/AT-hidden elements with tabindex
fixes #647