Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collect-results-from-frames): add frameWaitTime option #661

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

isner
Copy link
Contributor

@isner isner commented Dec 19, 2017

Closes #660

frame.addEventListener('load', function () {
var context = new Context(document);
var params = { frameWaitTime: 90000 };
axe.utils.collectResultsFromFrames(context, params, 'stuff', 'morestuff', noop,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to also cover this in an integration test, so we can make sure it works from axe.run?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specifically, across iframes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I've added an integration test.

@marcysutton marcysutton merged commit 8016ad1 into develop Jan 18, 2018
@marcysutton
Copy link
Contributor

Also merged to develop-2x. Thanks Matt!

@marcysutton marcysutton deleted the config-frame-timeout branch January 18, 2018 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants