fix: Overwrite incorrect sri-history entries #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
approved these changes
Mar 21, 2018
WilcoFiers
requested changes
Mar 21, 2018
|
@WilcoFiers Right you are. I've fixed that one too. |
|
I wonder if it's missing an automated build step so |
|
@marcysutton They added a bunch of lifecycle hooks to standard-version as of 4.1.0. That should help with this. |
mrtnvh
pushed a commit
to mrtnvh/axe-core
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I validated each of the sri-history entries manually and discovered that the following 3 versions have inaccurate entries:
I am personally responsible for adding the 2.4.2 and 2.6.1 entries. I'm fairly certain that I used the build/sri-update tool to generate those entries back when I added them, and today I generated the entries by
npm iing axe-core and generating the hash using the sri-toolbox module. I don't see why those two methods would produce different results, so I'm baffled. I'm guessing human error.