fix(accessible-name): Allow fallback labels when input has id #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
approved these changes
Jun 11, 2018
marcysutton
reviewed
Jun 11, 2018
test/commons/text/accessible-text.js
Outdated
| @@ -778,6 +778,18 @@ describe('text.accessibleTextVirtual', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should find implicit labels with id', function () { | |||
There was a problem hiding this comment.
Isn't the point of this test that the ID doesn't match the label? Might be good to add "invalid ID" in the test name
There was a problem hiding this comment.
How about "with id that does not match to a label"?
WilcoFiers
force-pushed
the
implicit-label-fix
branch
from
6ba28b8
to
a80e716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Description of the changes
I was poking around in the accessibleName method when I found/ noticed this little bug. It turns out that if you have an input element with an ID, Axe doesn't bother looking for an implicit label. That should obviously have been based on if there was actually an explicit label, not if the input has an ID.
Does this PR introduce a breaking change?
Other information