From 698e652b921769e39dc10c61a1d74d8c089e5e7a Mon Sep 17 00:00:00 2001 From: Steven Lambert Date: Tue, 18 Jun 2019 10:38:26 -0600 Subject: [PATCH 1/3] fix(radiogroup, checkboxgroup): deprecate radiogroup and checkboxgroup rules --- doc/rule-descriptions.md | 4 ++-- lib/rules/checkboxgroup.json | 1 + lib/rules/radiogroup.json | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md index 1f636c4c5f..dfe96f12f8 100644 --- a/doc/rule-descriptions.md +++ b/doc/rule-descriptions.md @@ -21,7 +21,7 @@ | blink | Ensures <blink> elements are not used | Serious | cat.time-and-media, wcag2a, wcag222, section508, section508.22.j | true | | button-name | Ensures buttons have discernible text | Critical | cat.name-role-value, wcag2a, wcag412, section508, section508.22.a | true | | bypass | Ensures each page has at least one mechanism for a user to bypass navigation and jump straight to the content | Serious | cat.keyboard, wcag2a, wcag241, section508, section508.22.o | true | -| checkboxgroup | Ensures related <input type="checkbox"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice | true | +| checkboxgroup | Ensures related <input type="checkbox"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice | false | | color-contrast | Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds | Serious | cat.color, wcag2aa, wcag143 | true | | css-orientation-lock | Ensures content is not locked to any specific display orientation, and the content is operable in all display orientations | Serious | cat.structure, wcag134, wcag21aa, experimental | true | | definition-list | Ensures <dl> elements are structured correctly | Serious | cat.structure, wcag2a, wcag131 | true | @@ -68,7 +68,7 @@ | object-alt | Ensures <object> elements have alternate text | Serious | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a | true | | p-as-heading | Ensure p elements are not used to style headings | Serious | cat.semantics, wcag2a, wcag131, experimental | true | | page-has-heading-one | Ensure that the page, or at least one of its frames contains a level-one heading | Moderate | cat.semantics, best-practice | true | -| radiogroup | Ensures related <input type="radio"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice | true | +| radiogroup | Ensures related <input type="radio"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice | false | | region | Ensures all page content is contained by landmarks | Moderate | cat.keyboard, best-practice | true | | role-img-alt | Ensures [role='img'] elements have alternate text | Serious | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a | true | | scope-attr-valid | Ensures the scope attribute is used correctly on tables | Moderate, Critical | cat.tables, best-practice | true | diff --git a/lib/rules/checkboxgroup.json b/lib/rules/checkboxgroup.json index 12ee4f7ddf..5e9bc4352e 100644 --- a/lib/rules/checkboxgroup.json +++ b/lib/rules/checkboxgroup.json @@ -6,6 +6,7 @@ "description": "Ensures related elements have a group and that the group designation is consistent", "help": "Checkbox inputs with the same name attribute value must be part of a group" }, + "enabled": false, "all": [], "any": ["group-labelledby", "fieldset"], "none": [] diff --git a/lib/rules/radiogroup.json b/lib/rules/radiogroup.json index 75cc346fed..a8a6cf318c 100644 --- a/lib/rules/radiogroup.json +++ b/lib/rules/radiogroup.json @@ -6,6 +6,7 @@ "description": "Ensures related elements have a group and that the group designation is consistent", "help": "Radio inputs with the same name attribute value must be part of a group" }, + "enabled": false, "all": [], "any": ["group-labelledby", "fieldset"], "none": [] From 07016cf02163b65e577efdabb434a8462fab05f2 Mon Sep 17 00:00:00 2001 From: Steven Lambert Date: Fri, 26 Jul 2019 09:43:59 -0600 Subject: [PATCH 2/3] adding deprecated tag --- lib/rules/checkboxgroup.json | 2 +- lib/rules/radiogroup.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/rules/checkboxgroup.json b/lib/rules/checkboxgroup.json index 5e9bc4352e..48f39ba9b0 100644 --- a/lib/rules/checkboxgroup.json +++ b/lib/rules/checkboxgroup.json @@ -1,7 +1,7 @@ { "id": "checkboxgroup", "selector": "input[type=checkbox][name]", - "tags": ["cat.forms", "best-practice"], + "tags": ["cat.forms", "best-practice", "deprecated"], "metadata": { "description": "Ensures related elements have a group and that the group designation is consistent", "help": "Checkbox inputs with the same name attribute value must be part of a group" diff --git a/lib/rules/radiogroup.json b/lib/rules/radiogroup.json index a8a6cf318c..cd376f1f3d 100644 --- a/lib/rules/radiogroup.json +++ b/lib/rules/radiogroup.json @@ -1,7 +1,7 @@ { "id": "radiogroup", "selector": "input[type=radio][name]", - "tags": ["cat.forms", "best-practice"], + "tags": ["cat.forms", "best-practice", "deprecated"], "metadata": { "description": "Ensures related elements have a group and that the group designation is consistent", "help": "Radio inputs with the same name attribute value must be part of a group" From 973c0f9df63208405a3ed5b62b538dccfdab434b Mon Sep 17 00:00:00 2001 From: Steven Lambert Date: Fri, 26 Jul 2019 09:44:19 -0600 Subject: [PATCH 3/3] rule descriptions --- doc/rule-descriptions.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md index dfe96f12f8..e47fe5b137 100644 --- a/doc/rule-descriptions.md +++ b/doc/rule-descriptions.md @@ -21,7 +21,7 @@ | blink | Ensures <blink> elements are not used | Serious | cat.time-and-media, wcag2a, wcag222, section508, section508.22.j | true | | button-name | Ensures buttons have discernible text | Critical | cat.name-role-value, wcag2a, wcag412, section508, section508.22.a | true | | bypass | Ensures each page has at least one mechanism for a user to bypass navigation and jump straight to the content | Serious | cat.keyboard, wcag2a, wcag241, section508, section508.22.o | true | -| checkboxgroup | Ensures related <input type="checkbox"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice | false | +| checkboxgroup | Ensures related <input type="checkbox"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice, deprecated | false | | color-contrast | Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds | Serious | cat.color, wcag2aa, wcag143 | true | | css-orientation-lock | Ensures content is not locked to any specific display orientation, and the content is operable in all display orientations | Serious | cat.structure, wcag134, wcag21aa, experimental | true | | definition-list | Ensures <dl> elements are structured correctly | Serious | cat.structure, wcag2a, wcag131 | true | @@ -68,7 +68,7 @@ | object-alt | Ensures <object> elements have alternate text | Serious | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a | true | | p-as-heading | Ensure p elements are not used to style headings | Serious | cat.semantics, wcag2a, wcag131, experimental | true | | page-has-heading-one | Ensure that the page, or at least one of its frames contains a level-one heading | Moderate | cat.semantics, best-practice | true | -| radiogroup | Ensures related <input type="radio"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice | false | +| radiogroup | Ensures related <input type="radio"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice, deprecated | false | | region | Ensures all page content is contained by landmarks | Moderate | cat.keyboard, best-practice | true | | role-img-alt | Ensures [role='img'] elements have alternate text | Serious | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a | true | | scope-attr-valid | Ensures the scope attribute is used correctly on tables | Moderate, Critical | cat.tables, best-practice | true |