From b68d8eb267aa757accb2c807d1329a04c9c42552 Mon Sep 17 00:00:00 2001 From: Steven Lambert Date: Wed, 17 Jun 2020 10:56:50 -0600 Subject: [PATCH 1/2] fix(aria-allowed-role): allow role=presentation on hr --- lib/commons/aria/lookup-table.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/commons/aria/lookup-table.js b/lib/commons/aria/lookup-table.js index c73997b5a7..4d13e3c9cf 100644 --- a/lib/commons/aria/lookup-table.js +++ b/lib/commons/aria/lookup-table.js @@ -1429,6 +1429,7 @@ lookupTable.role = { 'h5', 'h6', 'header', + 'hr', 'iframe', 'li', 'ol', @@ -1515,6 +1516,7 @@ lookupTable.role = { 'h5', 'h6', 'header', + 'hr', 'iframe', 'li', 'ol', From 1eca619c7a418a25b8fc2a80e7796f8907a071fc Mon Sep 17 00:00:00 2001 From: Steven Lambert Date: Wed, 17 Jun 2020 13:43:28 -0600 Subject: [PATCH 2/2] add test --- .../rules/aria-allowed-role/aria-allowed-role.html | 2 ++ .../rules/aria-allowed-role/aria-allowed-role.json | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/test/integration/rules/aria-allowed-role/aria-allowed-role.html b/test/integration/rules/aria-allowed-role/aria-allowed-role.html index 1ce0ea43d1..243ab26185 100644 --- a/test/integration/rules/aria-allowed-role/aria-allowed-role.html +++ b/test/integration/rules/aria-allowed-role/aria-allowed-role.html @@ -167,6 +167,8 @@

+ +
diff --git a/test/integration/rules/aria-allowed-role/aria-allowed-role.json b/test/integration/rules/aria-allowed-role/aria-allowed-role.json index 37de3d97a3..feefed99c2 100644 --- a/test/integration/rules/aria-allowed-role/aria-allowed-role.json +++ b/test/integration/rules/aria-allowed-role/aria-allowed-role.json @@ -64,7 +64,9 @@ ["#pass-dpub-4"], ["#pass-dpub-5"], ["#pass-dpub-6"], - ["#pass-dpub-7"] + ["#pass-dpub-7"], + ["#hr-presentation"], + ["#hr-none"] ], "violations": [ ["#fail-dd-no-role"],