Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(is-in-tab-order): add isInTabOrder to commons #3619

Merged
merged 13 commits into from
Aug 30, 2022
Merged

feat(is-in-tab-order): add isInTabOrder to commons #3619

merged 13 commits into from
Aug 30, 2022

Commits on Aug 24, 2022

  1. feat(is-in-tab-order): add commons.isInTabOrder()

    @dbowling
    dbowling committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    8fe6af8 View commit details
    Browse the repository at this point in the history

  2. fix IE / refactor

    @dbowling
    dbowling committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    27b2b78 View commit details
    Browse the repository at this point in the history

  3. skip test for IE11

    @dbowling
    dbowling committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    efae2c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
    @dbowling @WilcoFiers
    dbowling and WilcoFiers committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    0c8243d View commit details
    Browse the repository at this point in the history

  2. assert should match description

    @dbowling
    dbowling committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    b12541f View commit details
    Browse the repository at this point in the history

  3. convert to isInTabOrder

    @dbowling
    dbowling committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    79ad5f9 View commit details
    Browse the repository at this point in the history

  4. use isInTabOrder

    @dbowling
    dbowling committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    08073f7 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
    @dbowling @straker
    dbowling and straker committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    096c6b5 View commit details
    Browse the repository at this point in the history

  6. assert against text node

    @dbowling
    dbowling committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    270cd7c View commit details
    Browse the repository at this point in the history

  7. use isInTabOrder

    @dbowling
    dbowling committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    585eff0 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. revert

    @dbowling
    dbowling committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    f96a5a4 View commit details
    Browse the repository at this point in the history

  2. revert

    @dbowling
    dbowling committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    667f5ee View commit details
    Browse the repository at this point in the history

  3. revert

    @dbowling
    dbowling committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    a3dec82 View commit details
    Browse the repository at this point in the history