Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-required-children): set related nodes for invalid children #4033

Merged
merged 1 commit into from
May 24, 2023

Conversation

WilcoFiers
Copy link
Contributor

Ensure virtual nodes are accepted as related nodes. This prevented aria-required-children from reporting related nodes. I would've added a test to aria-required-children for related nodes, but it turned out it already has them. We just never noticed it wasn't working.

Closes: #4032

@WilcoFiers WilcoFiers requested a review from a team as a code owner May 23, 2023 14:11
true,
fixture.querySelector('b'),
'hello world',
new axe.SerialVirtualNode({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad you added this one. At first I thought it would go through so nice to see it in a test to ensure it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The aria-required-children rules should provide related nodes
2 participants