-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to mark a plugin as Dangerous/destructive #2604
Comments
Merged
gberche-orange
added a commit
to gberche-orange/k9s
that referenced
this issue
Jul 11, 2024
Relates to derailed#2604 introduced in derailed#2637
gberche-orange
added a commit
to gberche-orange/k9s
that referenced
this issue
Jul 12, 2024
Relates to derailed#2604 introduced in derailed#2637
gberche-orange
added a commit
to gberche-orange/k9s
that referenced
this issue
Jul 12, 2024
Relates to derailed#2604 introduced in derailed#2637
derailed
pushed a commit
that referenced
this issue
Aug 15, 2024
* Update README.md plugin for Shortcut and OverwriteOutput See https://github.com/derailed/k9s/blob/a07243dbb09ed8b7727e3229ac0314ed2e475d37/change_logs/release_0.8.0.md#L51 for supported * Update README.md with plugin dangerous field Relates to #2604 introduced in #2637
uozalp
pushed a commit
to uozalp/k9s
that referenced
this issue
Sep 2, 2024
* Update README.md plugin for Shortcut and OverwriteOutput See https://github.com/derailed/k9s/blob/a07243dbb09ed8b7727e3229ac0314ed2e475d37/change_logs/release_0.8.0.md#L51 for supported * Update README.md with plugin dangerous field Relates to derailed#2604 introduced in derailed#2637
thorbenbelow
pushed a commit
to thorbenbelow/k9s
that referenced
this issue
Nov 10, 2024
* Update README.md plugin for Shortcut and OverwriteOutput See https://github.com/derailed/k9s/blob/a07243dbb09ed8b7727e3229ac0314ed2e475d37/change_logs/release_0.8.0.md#L51 for supported * Update README.md with plugin dangerous field Relates to derailed#2604 introduced in derailed#2637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I heavily use read only mode to prevent fat-fingering a modification to my cluster when I just want to browse it; this works great for built-in actions, but all plugins can still be run. I've set my destructive ones to
confirm: true
but would prefer to have them inaccessible in read only mode, especially since I sometimes share my plugin definitions with others.Describe the solution you'd like
An additional optional boolean field
dangerous
in plugin definitions, that will remove the plugin from the actions list if k9s is in read only mode.Describe alternatives you've considered
I did look into if there was a way to deduce read/write mode from scope but couldn't find one. I also briefly considered writing a wrapper script that changed my plugin configuration live on disk based on the
--write
flag, but that seemed a bit out there and wouldn't work for having multiple clusters open in different k9s instances.The text was updated successfully, but these errors were encountered: