Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create an ignore list for lines #2

Closed
dirkschumacher opened this issue Jul 28, 2017 · 6 comments
Closed

create an ignore list for lines #2

dirkschumacher opened this issue Jul 28, 2017 · 6 comments

Comments

@dirkschumacher
Copy link

dirkschumacher commented Jul 28, 2017

What S-bahn line is this?

generate-vbb-graph -p suburban --simple-lines --simple-deduplication
...
{"source":"900000560222","target":"900000550239","relation":"suburban","metadata":{"line":"s","time":180}}
...
@derhuerst
Copy link
Owner

derhuerst commented Jul 28, 2017

It is from the static data:

curl -s 'https://vbb-gtfs.jannisr.de/latest/routes.txt' | grep 17599_109
# 17599_109,108,"s","",109,"","",""
curl -s 'https://vbb-gtfs.jannisr.de/latest/routes.txt' | grep 17604_109
# 17604_109,108,"s","",109,"","",""
curl -s 'https://vbb-gtfs.jannisr.de/latest/agency.txt' | grep 108
# 108,"DB Regio AG","http://www.bahn.de/brandenburg","Europe/Berlin","de",""

@derhuerst
Copy link
Owner

It is my fault though that I recognised it as a suburban train.

@derhuerst
Copy link
Owner

derhuerst/vbb-gtfs#2

@derhuerst
Copy link
Owner

It is my fault though that I recognised it as a suburban train.

Turns out this line actually appears as a suburban train in the static data.

@derhuerst
Copy link
Owner

We might want to use an ignore list as opt-in to exclude "crazy" lines like this one.

@derhuerst derhuerst changed the title Suburban has line "s" create an ignore list for lines Jul 31, 2017
@derhuerst
Copy link
Owner

PRs for the blacklist welcome! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants