Fixed clippy warnings #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dermesser
reviewed
Nov 14, 2019
| @@ -22,7 +20,7 @@ pub trait FixedInt: Sized + Copy { | |||
| v | |||
| } | |||
| /// Helper: Decode the value from the Vec. | |||
| fn decode_fixed_vec(v: &Vec<u8>) -> Self { | |||
| fn decode_fixed_vec(v: &[u8]) -> Self { | |||
There was a problem hiding this comment.
please undo this and similar changes, as the Vec is intended (for backwards compatibility at least, I acknowledge the limited usefulness.
If you disagree very strongly, just delete the whole method, as decode_fixed already does this.
There was a problem hiding this comment.
If you need backwards compatibility, I can revert this and mark this function as deprecated. Any thoughts?
| }; | ||
| } | ||
|
|
||
| fn encode_fixed(self, dst: &mut [u8]) { | ||
| assert_eq!(dst.len(), Self::REQUIRED_SPACE); | ||
| let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; | ||
| let encoded = unsafe { &*(&self as *const $t as *const [u8; $sz]) }; |
There was a problem hiding this comment.
is this to fix a clippy warning or your personal taste? Because I like the old way better :-)
There was a problem hiding this comment.
This is just to fix clippy warning, I don't have a personal taste for this. We can keep it the old way if it suits you better. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.