feat: Support custom fields in user-profile-widget + Edit/Delete flows #843
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d0925fe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
Nitzperetz
changed the title
...widget/src/lib/widget/mixins/initMixin/initComponentsMixins/initUserCustomAttributesMixin.ts
Outdated
Show resolved
Hide resolved
...widget/src/lib/widget/mixins/initMixin/initComponentsMixins/initUserCustomAttributesMixin.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Nitzan Peretz <nitzan@descope.com>
…om:descope/descope-js into feat/user_profile_widget_add_custom_fields
|
@nirgur added subscribe to |
|
I will be adding flows support in this PR. let's keep it open for now and not merge. |
…om:descope/descope-js into feat/user_profile_widget_add_custom_fields
Nitzperetz
changed the title
|
@nirgur added edit/delete flow support. |
| }); | ||
| } | ||
|
|
||
| #updateCustomValueUserAttrs = withMemCache( |
There was a problem hiding this comment.
This function is a bit big and contains some repetitive code
Do you think we could split it into smaller functions?
There was a problem hiding this comment.
It was really about keeping the same standards as the other mixin - to begin with a preferred extracting code to functions and reuse.
Let me see what I can do here
Related Issues
fixes https://github.com/descope/etc/issues/8220
Part of https://github.com/descope/etc/issues/6501
Description
Widget Profile widget to support custom fields presentation - created a new mixin to support custom fields userAttribute component.