Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'kerberos' pip dependency with 'gssapi' #34

Open
svmhdvn opened this issue Mar 28, 2024 · 5 comments
Open

Replace 'kerberos' pip dependency with 'gssapi' #34

svmhdvn opened this issue Mar 28, 2024 · 5 comments

Comments

@svmhdvn
Copy link

svmhdvn commented Mar 28, 2024

I'm currently working on an open source IT infrastructure project and
was trying to deploy a particular WSGI application with kerberos
support. I came across your project and would ideally like to use it in
the infrastructure. However, I'd just like to make some minor
improvements to it that should ideally benefit everyone.

Here are my proposals:

  • Change project documentation to reflect that this is a SPNEGO (GSSAPI)
    middleware layer that supports Kerberos as the authentication backend
  • Change the dependency on the relatively unmaintained and narrow python-kerberos[1] to
    the more general and well maintained gssapi[2].

I have the bandwidth to work on these changes now. I'd like to know if
these are reasonable proposals so that I can spend some time to submit a
PR to the project. Is that ok?

Thanks for the great project!

@propertone
Copy link
Member

Sounds ok in theory, but I'm not familiar with the kerberos vs gssapi python library difference. @mkomitee @nrhall - do you know more about this?

@nrhall
Copy link
Member

nrhall commented Apr 4, 2024

These seem like fine changes to me - I agree that the python GSSAPI module is the right way to go, looks like the author has now made the pykerberos repo read-only, and strictly this is indeed SPNEGO and not native kerberos...

@nrhall
Copy link
Member

nrhall commented Apr 4, 2024

Happy to review as and when you have something, thanks!

@propertone
Copy link
Member

Sounds good to me too then!

@svmhdvn
Copy link
Author

svmhdvn commented May 3, 2024

Any feedback on #35?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants