Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to optimize tree shaking #23

Open
jackson-dean opened this issue Oct 17, 2023 · 0 comments
Open

Refactor to optimize tree shaking #23

jackson-dean opened this issue Oct 17, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jackson-dean
Copy link
Collaborator

Describe the bug
Right now the identity class has methods that depend on the ethers library. These methods are not useful for the typical app and should not require bundling the ethers lib if it's not needed.

To Reproduce
Run a build using any js bundler: webpack, rollup, esbuild, etc. After importing and using any identity method (login, logout, etc). If you check the bundled output it includes the entire ethers lib.

Expected behavior
If we don't require and use any ethereum related functions, we should be able to tree shake away the ethers dependency.

@jackson-dean jackson-dean added the enhancement New feature or request label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant