From 319f70ad32ae34e81ffeaf4ab91cb3e1ec6010eb Mon Sep 17 00:00:00 2001 From: Tijno Date: Wed, 31 Aug 2022 08:10:56 +0000 Subject: [PATCH 1/3] switch to node 14.15.5 & npm 7 to resolve issues with Lockfile v2 --- .gitpod.Dockerfile | 8 ++++++++ .gitpod.yml | 4 ++++ 2 files changed, 12 insertions(+) create mode 100644 .gitpod.Dockerfile diff --git a/.gitpod.Dockerfile b/.gitpod.Dockerfile new file mode 100644 index 000000000..dcb283009 --- /dev/null +++ b/.gitpod.Dockerfile @@ -0,0 +1,8 @@ +FROM gitpod/workspace-full:latest + +RUN bash -c 'NODE_VERSION="14.15.5" \ + && source $HOME/.nvm/nvm.sh && nvm install $NODE_VERSION \ + && nvm use $NODE_VERSION && nvm alias default $NODE_VERSION \ + && npm -g install npm@7' + +RUN echo "nvm use default &>/dev/null" >> ~/.bashrc.d/51-nvm-fix \ No newline at end of file diff --git a/.gitpod.yml b/.gitpod.yml index 577bd0d5a..1843c0dc3 100644 --- a/.gitpod.yml +++ b/.gitpod.yml @@ -1,3 +1,7 @@ +# Use custom node & npm versions in image +image: + file: .gitpod.Dockerfile + # Commands to start on workspace startup tasks: - name: open terminial From cd8ff76a1b70eb61a7e3e772a1e0e76764875262 Mon Sep 17 00:00:00 2001 From: Tijno Date: Wed, 31 Aug 2022 08:11:11 +0000 Subject: [PATCH 2/3] Update readme with recommended version info --- README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index d6e881965..6ace6c34e 100644 --- a/README.md +++ b/README.md @@ -18,9 +18,13 @@ docs should give you everything you need to get started: - [Setting Up Your Dev Environment](https://docs.deso.org/code/dev-setup) - [Making Your First Changes](https://docs.deso.org/code/making-your-first-changes) +# Node / NPM versions + +This frontend works best with Node v14.15.5 and Npm v7. If you cant use these versions, then try `npm install --force`. + # Start Coding -The quickest way to contribute changes to the BitClout Frontend is the following these steps: +The quickest way to contribute changes to the Deso Frontend is the following these steps: 1. Open frontend repo in Gitpod From 54b35a3a788fb3b27b9f1af81691024205711929 Mon Sep 17 00:00:00 2001 From: "Tijno (@tijn on Deso)" <69529928+tijno@users.noreply.github.com> Date: Thu, 1 Sep 2022 01:47:45 +0100 Subject: [PATCH 3/3] Update README.md Co-authored-by: Lazy Nina <81658138+lazynina@users.noreply.github.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6ace6c34e..bf030fd70 100644 --- a/README.md +++ b/README.md @@ -24,7 +24,7 @@ This frontend works best with Node v14.15.5 and Npm v7. If you cant use these ve # Start Coding -The quickest way to contribute changes to the Deso Frontend is the following these steps: +The quickest way to contribute changes to the DeSo Frontend is the following these steps: 1. Open frontend repo in Gitpod