Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login.defs.j2 template: ENV_PATH is missing ':' before variable substitution #202

Closed
907th opened this issue Nov 9, 2018 · 3 comments
Closed
Assignees
Labels

Comments

@907th
Copy link

907th commented Nov 9, 2018

Describe the bug
I didn't test it, just read the sources and found that ENV_PATH variable in login.defs.j2 might be misconfigured when os_env_extra_user_paths is not empty (default = []).

Expected behavior
Items from os_env_extra_user_paths var should be separated from default ENV_PATH items with :.

Actual behavior
Current line 60 of login.defs.j2 contains:

ENV_PATH	PATH=/usr/local/bin:/usr/bin:/bin{{ os_env_extra_user_paths| join (':') }}
@rndmh3ro
Copy link
Member

rndmh3ro commented Nov 9, 2018

Hey @907th, thanks for reporting this! Definetly a bug, though. :( But its easy to fix! Do you want to create a PR or should I do this?

@907th
Copy link
Author

907th commented Nov 10, 2018

@rndmh3ro It is better you fix it. Thank you!

rndmh3ro pushed a commit that referenced this issue Nov 11, 2018
@rndmh3ro rndmh3ro self-assigned this Nov 11, 2018
rndmh3ro added a commit that referenced this issue Nov 11, 2018
add colon to user env paths - fix #202
@rndmh3ro
Copy link
Member

Fixed, thanks for bringing this up!

@rndmh3ro rndmh3ro added the bug label Nov 11, 2018
rndmh3ro added a commit that referenced this issue Jul 24, 2020
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
Signed-off-by: Sebastian Gumprich <github@gumpri.ch>
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants