add more sysctl settings, allow overwriting #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ypid
requested changes
Jun 5, 2017
tasks/sysctl.yml
Outdated
| @@ -19,6 +19,10 @@ | |||
| command: 'update-initramfs -u' | |||
| when: initramfs.changed | |||
|
|
|||
| - name: create a combined sysctl-dict if overwrites are defined | |||
| set_fact: sysctl_config="{{ sysctl_config | combine(sysctl_overwrite) }}" | |||
| when: sysctl_overwrite | default(omit) | |||
There was a problem hiding this comment.
Have you checked that omit evaluates to False? I would not rely on that. Just use default() which defaults to False 😉
There was a problem hiding this comment.
Thanks, I updated all the occurences!
ypid
requested changes
Jun 6, 2017
tasks/suid_sgid.yml
Outdated
| @@ -20,5 +20,5 @@ | |||
| - name: remove suid/sgid bit from all binaries except in system and user whitelist | |||
| file: path='{{item}}' mode='a-s' state=file follow=yes | |||
| with_items: | |||
| - '{{ suid | default(omit) | difference(os_security_suid_sgid_whitelist) }}' | |||
| - '{{ suid | default() | difference(os_security_suid_sgid_whitelist) }}' | |||
There was a problem hiding this comment.
In this case better use with_flattened and default([]) :) Similar goes with the other uses of default in with_items.
ypid
approved these changes
Jun 27, 2017
rndmh3ro
added a commit
that referenced
this pull request
Jul 24, 2020
Add support to specify a list of revoked public keys
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
add more sysctl settings, allow overwriting
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
Add support to specify a list of revoked public keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.