Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in computing softmax #5

Open
sinahmr opened this issue Apr 15, 2020 · 0 comments
Open

Problem in computing softmax #5

sinahmr opened this issue Apr 15, 2020 · 0 comments

Comments

@sinahmr
Copy link

sinahmr commented Apr 15, 2020

Hi, thank you for sharing this project.

I think line 108 should be changed from
return self.decode(z),F.softmax(q)
to
return self.decode(z), F.softmax(q_y, dim=-1).view(-1, latent_dim * categorical_dim).
Since the softmax should be taken on categorical_dim sized vectors, and not on latent_dim * categorical_dim sized ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant