Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : SSO with OpenID (OIDC) #48

Closed
matbgn opened this issue Jan 19, 2023 · 16 comments · Fixed by #56
Closed

Feature request : SSO with OpenID (OIDC) #48

matbgn opened this issue Jan 19, 2023 · 16 comments · Fixed by #56
Assignees
Labels
feature New feature to implement idea New idea to implement

Comments

@matbgn
Copy link

matbgn commented Jan 19, 2023

Would it be possible to implement a more open protocol for single sign-on like OIDC?

The open-source library Passport.js could be a solution if needed.

@heloufir heloufir added idea New idea to implement feature New feature to implement labels Jan 19, 2023
@heloufir
Copy link
Contributor

I will put this idea on the RoadMap project, I think it would be a good idea.

@heloufir heloufir moved this to Backlog in Helper RoadMap Jan 19, 2023
@matbgn
Copy link
Author

matbgn commented Jan 19, 2023

Based on the actual roadmap what will be a reasonable delay? With absolute no guarantee of course.

@heloufir
Copy link
Contributor

There is no other high priority task, so I think I will put it as a next step.
So in a week or two based on my free time

@heloufir
Copy link
Contributor

FYI
I think I will use this package https://github.com/jumbojett/OpenID-Connect-PHP I have pinned it a few days ago, so I will try it ASAP.

@heloufir heloufir moved this from Backlog to In Progress in Helper RoadMap Jan 19, 2023
@matbgn
Copy link
Author

matbgn commented Jan 19, 2023

😲 If you maintain this timeline I will, for sure, buy you a big coffee!

@heloufir
Copy link
Contributor

What do you think, just for fun 😄

row-1-column-1
row-2-column-1
row-3-column-1
row-4-column-1
row-5-column-1

@matbgn
Copy link
Author

matbgn commented Jan 19, 2023

🤣 ChatGPT apologies are enormous!

But personally I will go trough passport. It's a good battlefield tested library and I'm sure that you will be able to connect it with Connect2Id in one or the other way.

@heloufir
Copy link
Contributor

Lol yes there I can't even ask again 🤣

Yep, passport for me too is the best choice.

@heloufir
Copy link
Contributor

@matbgn any suggestions for local OIDC connect provider to make tests?

@matbgn
Copy link
Author

matbgn commented Jan 22, 2023

An easy and straightforward solution would be to use Authentik (https://github.com/goauthentik/authentik), personally I use Keycloak.

@heloufir
Copy link
Contributor

heloufir commented Jan 24, 2023

@matbgn

I just pushed the OIDC Connect function to dev branch, before merging it to master, I would like if possible that you test it in your local to check if the logic is good and match your needs.

To make it working in your local environment:

  1. Clone the repo: git clone https://github.com/devaslanphp/project-management-docs.git
  2. Change the branch to dev: git checkout dev
  3. Install dependencies (back & front): composer install && npm install
  4. Configure your .env file based on docs: https://devaslanphp.github.io/project-management/#/installation?id=configuration
  5. Configure your database based on docs: https://devaslanphp.github.io/project-management/#/installation?id=database
  6. Configure your OIDC environment variables: (based on this https://github.com/devaslanphp/project-management/blob/dev/docs/oidc.md)
OIDC_CLIENT_ID=
OIDC_CLIENT_SECRET=
OIDC_DISCOVERY_ENDPOINT=
OIDC_REDIRECT_URI="${APP_URL}/oidc/callback"
OIDC_REALM="myrealm"
OIDC_URL_AUTHORIZE="${OIDC_DISCOVERY_ENDPOINT}/realms/${OIDC_REALM}/protocol/openid-connect/auth"
OIDC_URL_ACCESS_TOKEN="${OIDC_DISCOVERY_ENDPOINT}/realms/${OIDC_REALM}/protocol/openid-connect/token"
OIDC_URL_RESOURCE_OWNER_DETAILS="${OIDC_DISCOVERY_ENDPOINT}/realms/${OIDC_REALM}/protocol/openid-connect/userinfo"
OIDC_SCOPE="openid"

Make sure you have already configured the OIDC environment variables before trying to authenticate your user based on your OIDC provider, and enabled the OIDC Connect login in your Administration General Settings

image

@heloufir
Copy link
Contributor

FYI
To enable / disable login sections (form, oidc and social) you can use the General settings.

image

@heloufir
Copy link
Contributor

@matbgn any news about this?

@heloufir heloufir linked a pull request Jan 31, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from Next release to Done in Helper RoadMap Jan 31, 2023
@matbgn
Copy link
Author

matbgn commented Mar 23, 2023

Finally I managed to deploy it on Caprover and made a PR on the community for its basic installation as a reward (sorry for the delay) see caprover/one-click-apps#888

Next I'll try with OIDC and get back to you or make a new issue specifically for that if needed, but I don't mind so.

@matbgn
Copy link
Author

matbgn commented Mar 23, 2023

As promised the coffee is on its way, enjoy! ☕

@heloufir
Copy link
Contributor

Finally I managed to deploy it on Caprover and made a PR on the community for its basic installation as a reward (sorry for the delay) see caprover/one-click-apps#888

Next I'll try with OIDC and get back to you or make a new issue specifically for that if needed, but I don't mind so.

That's great, thanks for your help!

As promised the coffee is on its way, enjoy! ☕

Thanks a lot mate! don't hesitate if you need any help, I have a lot to do, but I can help on my free time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature to implement idea New idea to implement
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants