Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink and junction arrows render incorrectly #68

Closed
MadameMinty opened this issue Feb 11, 2022 · 1 comment
Closed

Symlink and junction arrows render incorrectly #68

MadameMinty opened this issue Feb 11, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@MadameMinty
Copy link

MadameMinty commented Feb 11, 2022

Symlink and junction arrows render incorrectly on Windows default PowerShell (5.1.19041.1320).

Expected Behavior

When printing directory contents on Windows Terminal, symlinks and junctions display name as "icon link-name arrow target-name".

Current Behavior

When printing directory contents on Windows Terminal, symlinks and junctions display name as "icon link-name ï•” target-name".

image

Possible Solution

With 0.9.0, in Terminal-Icons.psm1:312 and Terminal-Icons.psm1:326 replace:
$displayInfo['Target'] = '  ' + $FileInfo.Target
with:
$displayInfo['Target'] = ' ' + $glyphs['nf-mdi-arrow_right_thick'] + ' ' + $FileInfo.Target

Steps to Reproduce (for bugs)

  1. Start Powershell
  2. mkdir Target
  3. mklink /J Link Target
  4. ls

Context

Arrows good. These are the only instances of explicit unicode glyphs in Terminal-Icons.psm1, so getting rid of them could be nice.

Your Environment

  • Module version used: 0.9.0
  • Operating System and PowerShell version: Windows 10, Windows Terminal, PSVersion 5.1.19041.1320. This is the system default.

PSVersion 7.2.0, which is installed separately, renders the glyph correctly.

@devblackops devblackops added the bug Something isn't working label Mar 3, 2022
@devblackops devblackops self-assigned this Mar 3, 2022
@devblackops
Copy link
Owner

Thanks @MadameMinty. This has been fixed in b022094.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants