Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure Container Registry anonymous pulls (and oauth2 pulls in general) #344

Closed
wants to merge 2 commits into from

Conversation

brendandburns
Copy link

@brendandburns brendandburns requested a review from a team as a code owner December 23, 2022 19:12
@joshspicer
Copy link
Member

Thanks for taking the time!

This looks great to patch/support Azure, although it's not generalized to support any registry that implements the docker spec (see issue discussion: #322)

I started working on #341 before I left for the holidays, which will implement the docker authorization spec.

@brendandburns do you know if Azure CR is implementing the docker spec (will send a 401 with an authorization endpoint to use in the WWW-Authenticate Header)? If so, it might make more sense to take my change instead as it will be more generic. If Azure is a special case then this makes a lot of sense to add in

@joshspicer
Copy link
Member

It appears ACR does implement the docker auth flow!
image

@joshspicer
Copy link
Member

I've merged #341, which should complete the goal of this PR and more.

Please feel free to create an issue and tag me in the issue if anything is missed that this PR would provide.

@joshspicer joshspicer closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants