Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Merge metadata logic for containerEnv - devcontainer build #392

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Bug fix: Merge metadata logic for containerEnv - devcontainer build #392

merged 3 commits into from
Feb 3, 2023

Conversation

samruddhikhandale
Copy link
Member

Fixes - #381

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner February 1, 2023 22:41
@samruddhikhandale samruddhikhandale mentioned this pull request Feb 1, 2023
Closed
@samruddhikhandale
Copy link
Member Author

The following tests are failing https://github.com/devcontainers/cli/actions/runs/4069380934/jobs/7009165123#step:7:4476
since quite a few days and is not related to this PR changes

Fetching a manifest is failing with the following error 👇

Did not fetch manifest: {“errors”:[{“code”:“MANIFEST_UNKNOWN”,“message”:“OCI index found, but accept header does not support OCI indexes”}]}

Looking at how to fix it!

chrmarti
chrmarti requested changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Should we remove containerEnv from up then?

src/spec-node/containerFeatures.ts Outdated Show resolved Hide resolved
src/spec-node/containerFeatures.ts Outdated Show resolved Hide resolved
@chrmarti
Copy link
Contributor

chrmarti commented Feb 2, 2023

I just now see: We still need containerEnv in up for the cases when we can avoid building a custom image (getExtendImageBuildInfo then skips getFeaturesBuildOptions).

chrmarti
chrmarti approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samruddhikhandale samruddhikhandale merged commit 77172a2 into main Feb 3, 2023
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/containerenv-bug branch February 3, 2023 17:26
@joshspicer joshspicer mentioned this pull request Mar 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrmarti chrmarti chrmarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samruddhikhandale @chrmarti