Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Features/Templates by digest #480

Merged
merged 5 commits into from
Apr 14, 2023

Conversation

joshspicer
Copy link
Member

ref: #479

Previously, all Features and Templates resolved a digest and associated manifest by tag. This change also allow resolving the Feature or Template by sha256 digest directly.

Eg:

{
  "features": {
    "ghcr.io/devcontainers/features/git-lfs@sha256:9e0b6df853ec932203945b76b9cfa7470ebd1f8bd765484027608581f9cf8a77": {}
  }
}

@joshspicer joshspicer requested a review from a team as a code owner April 5, 2023 00:17
@joshspicer joshspicer changed the title Fetch Features/Template by digest Fetch Features/Templates by digest Apr 5, 2023
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🔥

@joshspicer joshspicer requested a review from chrmarti April 5, 2023 22:36
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, otherwise looks great!

src/spec-configuration/containerCollectionsOCI.ts Outdated Show resolved Hide resolved
src/spec-configuration/containerCollectionsOCI.ts Outdated Show resolved Hide resolved
src/spec-configuration/containerCollectionsOCI.ts Outdated Show resolved Hide resolved
chrmarti
chrmarti previously approved these changes Apr 14, 2023
@joshspicer
Copy link
Member Author

joshspicer commented Apr 14, 2023

+ using this new functionality in an E2E test.

@joshspicer joshspicer enabled auto-merge (squash) April 14, 2023 18:52
@joshspicer joshspicer disabled auto-merge April 14, 2023 18:52
@joshspicer joshspicer merged commit fbf86e2 into main Apr 14, 2023
@joshspicer joshspicer deleted the joshspicer/fetch-feature-by-digest branch April 14, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants