Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden --omit-syntax-directive flag #728

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Jan 22, 2024

Unblocks bug with #syntax directives + buildkit + user namespace remapping by not auto-injecting the #syntax directive in the extended (Features) intermediate Dockerfile, and ignoring user-contributed syntax directives.

See moby/buildkit#4556 for more info.

Enable with hidden --omit-syntax-directive up and build flag. This flag will be removed once upstream is fixed.

ref: https://github.com/github/codespaces/issues/15748

@joshspicer joshspicer requested a review from a team as a code owner January 22, 2024 17:39
@joshspicer joshspicer self-assigned this Jan 22, 2024
@joshspicer joshspicer changed the title Add hidden --ignore-syntax-directive flag Add hidden --omit-syntax-directive flag Jan 22, 2024
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joshspicer joshspicer merged commit 2b0a491 into main Jan 22, 2024
37 checks passed
@joshspicer joshspicer deleted the joshspicer/ignore-syntax-directive branch January 22, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants